Add option to ignore empty reference #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to disable the default transition behaviour where passing a nil value to transition's pause, resume or cancel API will control all existing transitions. Some users, myself included, have had issues with accidentally passing an already removed transition reference to the transition API will affect all transitions. This new feature will allow users to optionally prevent that behaviour. This also introduces 3 new API calls that the users can use to explicitly control all existing transitions. The code changes will not break existing projects and using this feature will be opt-in.
|
Added a simple check where If the user has set the new |
Shchvova
pushed a commit
to coronalabs/corona-docs
that referenced
this pull request
Aug 21, 2020
Update existing documentation and add new documentation for timer and transition libraries to explain the changes introduced in: coronalabs/framework-timer#2 and coronalabs/framework-transition#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to disable the default transition behaviour where passing a nil value to transition's
transition.pause(),transition.resume()ortransition.cancel()API will control all existing transitions.Some users, myself included, have had issues with accidentally passing an already removed transition reference to one of the aforementioned functions, which has unintentionally affected all existing transitions.
This new feature will allow users to optionally prevent that behaviour. These code changes will not break (or even affect) any existing projects. If a user wishes to prevent this default behaviour, then they simply need to set:
transition.ignoreEmptyReference = trueThis PR also introduces 3 new API calls that the users can use to explicitly control all existing transitions:
transition.pauseAll(),transition.resumeAll()ortransition.cancelAll(). These new API calls are in line with the new and pending timer API calls.Fixes coronalabs/corona#55