CXXCBC-496: Convert C++ Public API Error handling to use couchbase::error #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mateusz <[email protected]>
…tions (#557) * change query, search, analytics_query to use couchbase::error * convert references to use couchbase::error, add as() in error_context * update error context json de/serialisation * clang-format * review updates * add impl/retry_reason * fix imports * re-add search_query * change names from ctx to err/error * small changes * remove import * json default_key, retry_reason namespace * remove tao json default key macros * ctx -> err reference
* Convert management operation to use couchbase::error * remove unecessary imports * remove internal/manager error context * remove unecessary namespace * remove const reference from check
* Convert management operation to use couchbase::error * remove unecessary imports * couchbase::error transaction changes * clang-format * make error polymorphic * clang format and cleanup * always format retry attempts, add ec for query parsing * split TOF into public-facing tof which inherits couchbase::error * Add internal codedoc for public TOF * clang-format * convert to using internal_metadata for TOF fields * Remove public TOF * remove static, fix test * remove virtual destructor from error * fix import order
…567) * Change connect, ping, diagnostics to use couchbase::error * fix fmt error * rename ec to err * format whole error instead of message
avsej
force-pushed
the
CXXCBC-496-error
branch
3 times, most recently
from
ba917a0 to
e7178f0
Compare
* origin/main: CXXCBC-407: allow to use 0 max expiry for new collections (#569) CXXCBC-445: return request_canceled on IO error in HTTP session (#568) CXXCBC-509: Zone-Aware replica reads (#566) CXXCBC-511: Prevent use of HTTP session if idle timer has expired (#565) Improve test stability (#563) Always attempt to extract common query code if error has not been set (#561) Add feature check for scoped analyze_document in tests (#555) CXXCBC-30 Inconsistent behaviour when using subdoc opcodes incorrectly (#559) CXXCBC-503 - Additions for more protection against picking up a config with an empty vbucket map. (#558) CXXCBC-503: Ignore configuration if it contains an empty vBucketMap (#556) CXXCBC-489: Add version_7_2_0 eventing function language compatibility (#554)
avsej
previously approved these changes
May 22, 2024
* origin/main: CXXCBC-516: Return feature_not_available when upserting vector search index to incompatible cluster (#572) CXXCBC-509: Add feature flag for zone-aware replica reads (#571)
avsej
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes