Skip to content

CXXCBC-615: Expose insert_raw & replace_raw in core txns attempt ctx #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

DemetrisChr
Copy link
Contributor

@DemetrisChr DemetrisChr commented Oct 24, 2024

  • Expose insert_raw and replace_raw in the core txns attempt context APIs, which have now been renamed to insert and replace.
  • Remove the variants of insert and replace that use transcoders from the core API, as well as the overloads of core::transactions::transaction_get_result::content() that use transcoders
    • The C++ Public API, as well as the wrappers, have their own transcoder support, which makes these redundant.

@DemetrisChr DemetrisChr force-pushed the CXXCBC-615-insert-replace-raw branch from ffc751b to d3460a6 Compare October 25, 2024 13:23
@DemetrisChr DemetrisChr requested a review from avsej October 25, 2024 13:26
Copy link
Contributor

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Also tested w/ the PYCBC-1595 changes. Thanks for making the updates!

@avsej avsej merged commit 3d9e4bf into couchbase:main Oct 25, 2024
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants