Skip to content

[time.format] A minor update for LWG 4124 #7697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

Conversation

xmcgcg
Copy link
Contributor

@xmcgcg xmcgcg commented Feb 19, 2025

The resolution of LWG 4124 added an exception rule for “omitting chrono-specs”, therefore [time.format] p7 should begin with “unless otherwise specified” to avoid conflicts.

This PR also added two missing commas in [time.format].

@tkoeppe tkoeppe requested a review from jwakely June 17, 2025 13:28
@jwakely
Copy link
Member

jwakely commented Jun 17, 2025

The resolution of LWG 4124 added an exception rule for “omitting chrono-specs”, therefore [time.format] p7 should begin with “unless otherwise specified” to avoid conflicts.

I'm not sure what you mean here, what kind of conflicts?

How would it be otherwise specified? The wording is specifying precisely the case where chrono-specs is omitted in a format-spec which uses this formatter specialization. There is no otherwise possible, is there?

@jwakely
Copy link
Member

jwakely commented Jun 17, 2025

Oh I see what you mean, p7 says it means one thing, and p18 says otherwise.

But "unless otherwise specified" is always implied. A more specific rule always overrides a more general one.

This wouldn't do any harm though.

@tkoeppe tkoeppe merged commit 9dfb02a into cplusplus:main Jun 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants