Skip to content

refactored cc-tech-archive to align with vocab markup #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Queen-codes
Copy link
Contributor

Fixes

Description

This PR refactors page-with-title.html which serves as the template for the cc-tech-archives page to align with vocabulary markup

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Queen-codes Queen-codes requested review from a team as code owners January 9, 2025 16:03
@Queen-codes Queen-codes requested review from TimidRobot, Shafiya-Heena and akmadian and removed request for a team January 9, 2025 16:03
@TimidRobot TimidRobot self-assigned this Jan 9, 2025
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I also think it's a good place to fix the footer. The footer is the only way to navigate to the archives.

Footer currently has:

For this site, it should have:

@Queen-codes
Copy link
Contributor Author

This looks good, but I also think it's a good place to fix the footer. The footer is the only way to navigate to the archives.

Footer currently has:

For this site, it should have:

Hi @TimidRobot . Does this change as a localized change seeing as it is only applicable to this website only

@TimidRobot
Copy link
Member

Hi @TimidRobot . Does this change as a localized change seeing as it is only applicable to this website only

@Queen-codes no, I don't think so. It's not a deviation from Vocabulary as much as it is a customization empowered by Vocabulary. Vocabulary is acting like a template, in this regard. There's no expectation that the links in that part of the footer will be the same across sites that use Vocabulary.

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, thank you!

@TimidRobot TimidRobot merged commit 32145f0 into creativecommons:vocab-refresh Jan 9, 2025
1 check passed
@Queen-codes Queen-codes deleted the refactor-cc-tech-archive branch January 11, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants