Skip to content

Conversation

mnort9
Copy link
Contributor

@mnort9 mnort9 commented Aug 13, 2025

What this does

Adds gpt-5, gpt-5-mini, and gpt-5-nano capabilities.

I tried to run overcommit, but it updated more files than I expected so not sure if this is still used on every commit. I did run rubocop/tests.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Performance improvement

Scope check

  • I read the Contributing Guide
  • This aligns with RubyLLM's focus on LLM communication
  • This isn't application-specific logic that belongs in user code
  • This benefits most users, not just my specific use case

Quality check

  • I ran overcommit --install and all hooks pass
  • I tested my changes thoroughly
  • I updated documentation if needed
  • I didn't modify auto-generated files manually (models.json, aliases.json)

API changes

  • Breaking change
  • New public methods/classes
  • Changed method signatures
  • No API changes

@crmne
Copy link
Owner

crmne commented Aug 13, 2025

- **Model data fixes** → File with [Parsera](https://github.com/parsera-labs/api-llm-specs/issues)

@crmne crmne closed this Aug 13, 2025
@mnort9
Copy link
Contributor Author

mnort9 commented Aug 13, 2025

@crmne I ran into this issue b/c function calling wasn't working for gpt-5-mini & gpt-5-nano.

Parsera seems to be missing info on some models capabilities, modalities even on somewhat older models like gpt-4.1:

Screenshot 2025-08-13 at 5 15 06 PM

--

I noticed gpt-4.1 capabilities were hardcoded, so I figured this was in place since Parsera has some data missing.

def supports_functions?(model_id)
case model_family(model_id)
when 'gpt41', 'gpt41_mini', 'gpt41_nano', 'gpt4', 'gpt4_turbo', 'gpt4o', 'gpt4o_mini', 'o1', 'o1_pro',
'o3_mini' then true

I can open an issue with Parsera still, it just didn't look like there was too much activity in that repo.

@crmne
Copy link
Owner

crmne commented Aug 13, 2025

Please do file an issue with Parsera directly: https://github.com/parsera-labs/api-llm-specs/issues

If users don't report issues, Parsera won't know what's broken. The more reports they get, the more likely they'll fix it.

@crmne
Copy link
Owner

crmne commented Aug 13, 2025

@mnort9 you know what? Screw gatekeeping capabilities.

I removed that in 836113f

Thanks for the inspiration!

@crmne
Copy link
Owner

crmne commented Aug 14, 2025

Shipping it in 1.6.2 today.

@mnort9
Copy link
Contributor Author

mnort9 commented Aug 14, 2025

@crmne Awesome thank you!

Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.58%. Comparing base (0cb6299) to head (e5c0874).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   84.57%   84.58%           
=======================================
  Files          37       37           
  Lines        1932     1933    +1     
  Branches      499      500    +1     
=======================================
+ Hits         1634     1635    +1     
  Misses        298      298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@crmne
Copy link
Owner

crmne commented Sep 15, 2025

Still discussing potential solutions with Parsera, but let's reopen this and get it merged for now at least.

@crmne crmne merged commit df8ef75 into crmne:main Sep 15, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants