Update check, list, outdated commands to work against source changes and overrides #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to check resolver or apply overrides in list command
bcardiff
force-pushed
the
fix/commands-source-override
branch
from
7d40346 to
8f8ca5b
Compare
waj
approved these changes
Aug 5, 2020
taylor
pushed a commit
to vulk/shards
that referenced
this pull request
Aug 11, 2020
…and overrides (crystal-lang#429) * Fix check command to handle different sources * Fix check command to handle overrides * Add list command spec to handle source change and override No need to check resolver or apply overrides in list command * Update specs description * Fix outdated command to handle different sources * Fix outdated command to detect invalid lock * Fix outdated command to handle overrides
f-fr
pushed a commit
to f-fr/shards
that referenced
this pull request
Jan 2, 2021
…and overrides (crystal-lang#429) * Fix check command to handle different sources * Fix check command to handle overrides * Add list command spec to handle source change and override No need to check resolver or apply overrides in list command * Update specs description * Fix outdated command to handle different sources * Fix outdated command to detect invalid lock * Fix outdated command to handle overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #428Some minor fixes to deal with source changes and overrides on the listed commands.