feat(cubesql): SQL push down multiple window expressions with different sort keys #8788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR adds SQL push down support for multiple window expressions with different sort keys. In cases where there are several window function expressions in a
SELECT
and theyORDER BY
different keys, DataFusion generates severalWindowAggr
nodes on top of each other, with window expressions grouped by sort keys. Joining them together is invalid in terms of DataFusion logical plan, but having them together in a wrapped select is fine. Related test is added.