Skip to content

feat(schema-compiler): Introduce case insensitive member names duplicates check #9349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Mar 14, 2025

This PR adds the ability to do case insensitive cube/views member names duplicates checks

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon marked this pull request as ready for review March 17, 2025 17:29
@KSDaemon KSDaemon requested review from a team as code owners March 17, 2025 17:29
@KSDaemon KSDaemon force-pushed the feat/case-insensitive-dup-check branch 2 times, most recently from bedb8c5 to 4745a93 Compare March 27, 2025 10:49
@KSDaemon KSDaemon force-pushed the feat/case-insensitive-dup-check branch from 4745a93 to d16bcde Compare April 7, 2025 09:30
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 90.76923% with 12 lines in your changes missing coverage. Please review.

Project coverage is 48.14%. Comparing base (452633c) to head (d16bcde).

Files with missing lines Patch % Lines
...kages/cubejs-schema-compiler/src/compiler/utils.ts 78.26% 5 Missing and 5 partials ⚠️
packages/cubejs-backend-shared/src/env.ts 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (452633c) and HEAD (d16bcde). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (452633c) HEAD (d16bcde)
cubesql 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9349       +/-   ##
===========================================
- Coverage   76.40%   48.14%   -28.27%     
===========================================
  Files         400      171      -229     
  Lines      104055    21421    -82634     
  Branches     3685     3709       +24     
===========================================
- Hits        79508    10314    -69194     
+ Misses      24112    10668    -13444     
- Partials      435      439        +4     
Flag Coverage Δ
cube-backend 48.14% <90.76%> (+0.26%) ⬆️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant