test(cubestore): Fix decimal_partition_pruning test in release mode #9378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the test wait for or induce compaction first. In release mode the test had been failing. Cherry-picked from the DF upgrade branch.
srh
force-pushed
the
testfix-decimal_partition_pruning
branch
from
d83614d to
c75514f
Compare
ovr
reviewed
Mar 24, 2025
| .unwrap(); | ||
| // Semi-busy-wait for, or, seemingly, induce, compaction for 2000 ms. | ||
| let num_attempts = 100; | ||
| for i in 0..num_attempts { |
There was a problem hiding this comment.
I believe it's better to use JobResultListener and wait_for_job_results here or metastore listener.
There was a problem hiding this comment.
It is not clear to me what job to wait for. Based on logs, some sort of PartitionCompaction job. But I don't know the right way to see which ones I want to wait on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the test wait for or induce compaction first. In release mode the test had been failing.
Cherry-picked from the DF upgrade branch.
Check List