Skip to content

feat(tesseract): Basic pre-aggregations support #9434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

waralexrom
Copy link
Member

@waralexrom waralexrom commented Apr 7, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 45 lines in your changes missing coverage. Please review.

Project coverage is 80.39%. Comparing base (183c35a) to head (a171be9).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 17.07% 34 Missing ⚠️
...ejs-schema-compiler/src/adapter/PreAggregations.js 23.07% 10 Missing ⚠️
...bejs-schema-compiler/src/compiler/CubeEvaluator.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9434      +/-   ##
==========================================
- Coverage   83.96%   80.39%   -3.58%     
==========================================
  Files         230      395     +165     
  Lines       84004    97932   +13928     
  Branches        0     2278    +2278     
==========================================
+ Hits        70536    78731    +8195     
- Misses      13468    18893    +5425     
- Partials        0      308     +308     
Flag Coverage Δ
cube-backend 57.33% <18.18%> (?)
cubesql 84.09% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@waralexrom waralexrom force-pushed the tesseract-basic-pre-aggregations branch from be6e357 to ccf4c02 Compare April 21, 2025 18:11
@waralexrom waralexrom changed the base branch from master to tesseract-logical-plan April 21, 2025 18:12
@waralexrom waralexrom force-pushed the tesseract-logical-plan branch from 2d7ac7e to 37e2479 Compare April 28, 2025 08:37
Base automatically changed from tesseract-logical-plan to master April 28, 2025 09:33
@waralexrom waralexrom force-pushed the tesseract-basic-pre-aggregations branch from ccf4c02 to 09309d0 Compare April 28, 2025 18:43
@waralexrom waralexrom marked this pull request as ready for review May 1, 2025 14:20
@waralexrom waralexrom requested a review from a team as a code owner May 1, 2025 14:20
@waralexrom waralexrom force-pushed the tesseract-basic-pre-aggregations branch from 995c326 to 335c2ed Compare May 1, 2025 14:51
@waralexrom waralexrom requested a review from KSDaemon May 1, 2025 16:56
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 This is great!

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 This is great! However there are some places need fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants