Skip to content

fix(schema-compiler): Fix incorrect bulk transpilation if there are no JS files #9453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

KSDaemon
Copy link
Member

No description provided.

@KSDaemon KSDaemon marked this pull request as ready for review April 11, 2025 13:41
@KSDaemon KSDaemon requested a review from a team as a code owner April 11, 2025 13:41
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 47.85%. Comparing base (4d1b17a) to head (654ce17).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...schema-compiler/src/compiler/DataSchemaCompiler.js 0.00% 11 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4d1b17a) and HEAD (654ce17). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (4d1b17a) HEAD (654ce17)
cubesql 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9453       +/-   ##
===========================================
- Coverage   83.91%   47.85%   -36.06%     
===========================================
  Files         229      171       -58     
  Lines       83657    21422    -62235     
  Branches        0     3711     +3711     
===========================================
- Hits        70197    10252    -59945     
+ Misses      13460    10738     -2722     
- Partials        0      432      +432     
Flag Coverage Δ
cube-backend 47.85% <0.00%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the fix/bulk-transpile branch from f782735 to 654ce17 Compare April 11, 2025 14:01
@KSDaemon KSDaemon merged commit 610820f into master Apr 11, 2025
59 checks passed
@KSDaemon KSDaemon deleted the fix/bulk-transpile branch April 11, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants