-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(backend-native): Allow importing modules from python files within cube.py
and globals.py
#9490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9490 +/- ##
==========================================
- Coverage 80.28% 80.27% -0.01%
==========================================
Files 395 395
Lines 97355 97355
Branches 2278 2278
==========================================
- Hits 78158 78150 -8
- Misses 18889 18897 +8
Partials 308 308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
12c6da6
to
dece67e
Compare
cube.py
and globals.py
dece67e
to
23a6975
Compare
60f0048
to
e4d6751
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor nit.
e4d6751
to
3c79f20
Compare
This fix allows to import python modules from files relative to
cube.py
. See more info and issue description in #8443.Closes #8443
Check List