Skip to content

feat(schema-compiler): Support overriding title, description, meta, and format on view members #9496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 23, 2025

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Apr 21, 2025

This change allows to override of some descriptive properties in the view's included members.

So now it's possible to do things like this:

        views:
          - name: orders_view
            cubes:
              - join_path: orders
                includes:
                - name: status
                  alias: my_beloved_status
                  title: My Beloved and not Favorite Status!    <<<<<<< this <<<<<<<
                  description: Don't you believe this?          <<<<<<< this <<<<<<<
                  meta:                                         <<<<<<< this. Please note, <<<<<<<
                    - c1: iddqd                                 <<<<<<< that Meta is overridden as a whole <<<<<<<
                    - c2: idkfa                                 <<<<<<< and not extended <<<<<<<

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon force-pushed the feat/views-override branch from 35638b8 to 9a0abad Compare April 21, 2025 10:55
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Project coverage is 59.02%. Comparing base (9319b0d) to head (0d568d4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...cubejs-schema-compiler/src/compiler/CubeSymbols.ts 75.00% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9496      +/-   ##
==========================================
+ Coverage   58.97%   59.02%   +0.05%     
==========================================
  Files         153      153              
  Lines       13053    13067      +14     
  Branches     2212     2223      +11     
==========================================
+ Hits         7698     7713      +15     
+ Misses       5040     5039       -1     
  Partials      315      315              
Flag Coverage Δ
cube-backend 59.02% <77.41%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the feat/views-override branch from 9a0abad to 6e49779 Compare April 21, 2025 17:27
@KSDaemon KSDaemon marked this pull request as ready for review April 21, 2025 19:03
@KSDaemon KSDaemon requested a review from a team as a code owner April 21, 2025 19:03
@KSDaemon KSDaemon force-pushed the feat/views-override branch from 6e49779 to 0d568d4 Compare April 23, 2025 12:01
@KSDaemon KSDaemon merged commit e0179c5 into master Apr 23, 2025
69 checks passed
@KSDaemon KSDaemon deleted the feat/views-override branch April 23, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants