Skip to content

fix(schema-compiler): Fix non-match for exact custom granularity pre-aggregation #9517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Apr 25, 2025

This fixes cases when a query with custom granularity doesn't hit the pre-aggregation with the same custom granularity.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.46%. Comparing base (4098c28) to head (4da3369).
Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4098c28) and HEAD (4da3369). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4098c28) HEAD (4da3369)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9517       +/-   ##
===========================================
- Coverage   80.23%   58.46%   -21.78%     
===========================================
  Files         399      169      -230     
  Lines       97815    13988    -83827     
  Branches     2275     2275               
===========================================
- Hits        78485     8178    -70307     
+ Misses      19015     5495    -13520     
  Partials      315      315               
Flag Coverage Δ
cube-backend 58.46% <100.00%> (-0.01%) ⬇️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review April 25, 2025 11:39
@KSDaemon KSDaemon requested a review from a team as a code owner April 25, 2025 11:39
Copy link
Member

@mcheshkov mcheshkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not the right person to ask for intricacies of granularities
I'd add one more test for query with preaggregation references alone, without date range

@KSDaemon KSDaemon force-pushed the fix/debug-preagg-custom-gran branch from 87a2566 to 4da3369 Compare April 28, 2025 10:17
@KSDaemon KSDaemon merged commit 313a606 into master Apr 28, 2025
59 checks passed
@KSDaemon KSDaemon deleted the fix/debug-preagg-custom-gran branch April 28, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants