Skip to content

feat(databricks-jdbc-driver): Implement connection checking without waking up SQL warehouse #9529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Apr 30, 2025

This updates Databricks test connection flow to use REST API instead of establishing real JDBC connection (which prevents SQL WH from suspending)

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon force-pushed the feat/databricks-test-conn-non-awake branch 3 times, most recently from 453a51a to e1990de Compare April 30, 2025 11:52
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.50%. Comparing base (940c30f) to head (76897d0).
Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (940c30f) and HEAD (76897d0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (940c30f) HEAD (76897d0)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9529       +/-   ##
===========================================
- Coverage   80.28%   57.50%   -22.78%     
===========================================
  Files         395      165      -230     
  Lines       97355    13504    -83851     
  Branches     2278     2278               
===========================================
- Hits        78158     7766    -70392     
+ Misses      18889     5430    -13459     
  Partials      308      308               
Flag Coverage Δ
cube-backend 57.50% <ø> (ø)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review April 30, 2025 12:17
@KSDaemon KSDaemon requested a review from a team as a code owner April 30, 2025 12:17
@KSDaemon KSDaemon force-pushed the feat/databricks-test-conn-non-awake branch from e1990de to a484454 Compare April 30, 2025 12:30
@KSDaemon KSDaemon force-pushed the feat/databricks-test-conn-non-awake branch from a484454 to 76897d0 Compare April 30, 2025 15:23
@KSDaemon KSDaemon requested a review from mcheshkov April 30, 2025 15:23
@KSDaemon KSDaemon merged commit 044341e into master Apr 30, 2025
59 checks passed
@KSDaemon KSDaemon deleted the feat/databricks-test-conn-non-awake branch April 30, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants