Skip to content

fix(schema-compiler): Reject pre-agg if measure is unmultiplied in query but multiplied in pre-agg #9541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: chore/preaggs-2-ts
Choose a base branch
from

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented May 2, 2025

This PR fixes the case when the request has a measure that is not treated as multiplied (e.g. no dimensions requested), but the same measure in the pre-aggregation is stored as multiplied, because of existence of miltiplier-dimension. Previously such queries were served by pre-agg, while it should not.

Depends on #9538

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon changed the title Fix/multiplied measure hit pre agg fix(schema-compiler): Reject pre-agg if measure is unmultiplied in query but multiplied in pre-agg May 2, 2025
Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.51%. Comparing base (18237b0) to head (eb5f53f).

Files with missing lines Patch % Lines
...ejs-schema-compiler/src/adapter/PreAggregations.ts 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           chore/preaggs-2-ts    #9541      +/-   ##
======================================================
+ Coverage               57.32%   57.51%   +0.19%     
======================================================
  Files                     165      165              
  Lines                   13544    13556      +12     
  Branches                 2387     2389       +2     
======================================================
+ Hits                     7764     7797      +33     
+ Misses                   5449     5428      -21     
  Partials                  331      331              
Flag Coverage Δ
cube-backend 57.51% <93.33%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the fix/multiplied-measure-hit-pre-agg branch from b659fb7 to eb5f53f Compare May 2, 2025 15:48
@KSDaemon KSDaemon marked this pull request as ready for review May 2, 2025 16:38
@KSDaemon KSDaemon requested a review from a team as a code owner May 2, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant