Skip to content

fix(query-orchestrator): Correct local date parsing for partition start/end queries #9543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 7, 2025
Merged

fix(query-orchestrator): Correct local date parsing for partition start/end queries #9543

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
73d128d
code polish
KSDaemon May 5, 2025
465d6fd
Refactor a bit
KSDaemon May 5, 2025
a3a2999
Add tests for daily partitions
KSDaemon May 5, 2025
b101851
refactor parseLocalDate to use UTC during parsing and then input time…
KSDaemon May 5, 2025
4511cce
tests
KSDaemon May 5, 2025
4f2d86e
fix tests
KSDaemon May 5, 2025
ee00575
fix test
KSDaemon May 5, 2025
ee08700
another test fix
KSDaemon May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
another test fix
  • Loading branch information
@KSDaemon
KSDaemon committed May 5, 2025
commit ee087002e4f7a04b9d4af9beaf2fa605169b0c4c
2 changes: 1 addition & 1 deletion packages/cubejs-server-core/test/unit/RefreshScheduler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,7 @@ describe('Refresh Scheduler', () => {
clearInterval(interval);

expect(mockDriver.createdTables.filter(o => o.tableName.includes('foo_first') && o.timezone === 'UTC').length).toEqual(3);
expect(mockDriver.createdTables.filter(o => o.tableName.includes('foo_first') && o.timezone === 'America/Los_Angeles').length).toEqual(3);
expect(mockDriver.createdTables.filter(o => o.tableName.includes('foo_first') && o.timezone === 'America/Los_Angeles').length).toEqual(2);
expect(mockDriver.createdTables.filter(o => o.tableName.includes('foo_orphaned')).length).toEqual(0);
expect(mockDriver.createdTables.filter(o => o.tableName.includes('foo_second')).length).toEqual(0);
});
Expand Down