Add caching of conditional directive chains #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmar
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds caching for
elif,else, andendiftokens that followif,elif, andelsethe first time they're processed, so that the preprocessor can jump directly to them the next time the conditional block should be skipped.The next conditional token is cached in the previous token's
mutable const Token *nextcond. Having a public mutable member is a bit awkward but seemed like the best solution. The alternative would be to makenextcondprivate and makepreprocessa friend, or make preprocess take a non-constTokenList.In the test case that I used for #447 this change brings the runtime down from over 12 minutes to less than one minute.