-
Notifications
You must be signed in to change notification settings - Fork 26
implement dart:mirrors #199
Comments
This is a very bare bones version - just enough to get angular running. See #199 [email protected] Review URL: https://codereview.chromium.org/1186683005.
The basic parts of this (i.e., the parts used by angular) are landed. This is still missing a lot of features - general method / function mirrors, parameter names, etc. |
Angular is now using parameter annotations as well (only for constructors). |
should be easy to implement now, given that we track parameter types? |
Yeah, we've already got code for class-level annotations too, mainly we just need to decide how we want to encode it. |
This unblocks angular. See #199 [email protected] Review URL: https://codereview.chromium.org/1252953003 .
Angular is now using https://api.dartlang.org/1.13.0/dart-mirrors/DeclarationMirror/owner.html This will require us to embed a pointer in classes back to the containing library in generated code. |
A little more implementation and workarounds for Angular. See #199. [email protected] Review URL: https://codereview.chromium.org/1489043002 .
Some more items required for Angular apps in mirrors mode:
All of these will require additional compile-time metadata. |
I guess the intended workflow is such that 'reflectable' would not be helpful here, as long as it is running as a pub transformer? |
Yes, this is just a convenience to run Angular2 apps without transformation. |
LibraryMirror.uri is important for some rare cases of unit testing: dart-lang/test#110 requires this to find assets for a test. |
About 50 tests pass right now. A bunch more fail. See #199 [email protected] Review URL: https://codereview.chromium.org/2256393002 .
Bumping and taking. We need some of this for testing support. |
This issue was moved to dart-lang/sdk#27268 |
Implement the dart:mirrors API. We should be able to map this to our dynamic invocation code / metadata.
The text was updated successfully, but these errors were encountered: