This repository was archived by the owner on Feb 10, 2025. It is now read-only.
Fix comment reference issues, among other new lints #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
commented
Oct 12, 2022
| @@ -21,7 +21,7 @@ final _specKey = Object(); | |||
| /// A chain of stack traces. | |||
| /// | |||
| /// A stack chain is a collection of one or more stack traces that collectively | |||
| /// represent the path from [main] through nested function calls to a particular | |||
| /// represent the path from `main` through nested function calls to a particular | |||
There was a problem hiding this comment.
This showed up on pub.dev – sadly the rest of the errors are just noise between pkg:lints/analyzer and dartdoc
kevmoo
commented
Oct 12, 2022
| /// convert JavaScript traces into Dart-style traces. | ||
| /// | ||
| /// [source_map_stack_trace]: https://pub.dev/packages/source_map_stack_trace | ||
| /// [`source_map_stack_trace`](https://pub.dev/packages/source_map_stack_trace) |
There was a problem hiding this comment.
I really wish this was fixed!
kevmoo
commented
Oct 12, 2022
| Description describe(Description description) => | ||
| description.add(_description).add(' ').addDescriptionOf(_matcher); | ||
| } | ||
| isA<Frame>().having((p0) => p0.library, 'library', matcher); |
natebosch
reviewed
Oct 12, 2022
Co-authored-by: Nate Bosch <[email protected]>
Co-authored-by: Nate Bosch <[email protected]>
Co-authored-by: Nate Bosch <[email protected]>
Co-authored-by: Nate Bosch <[email protected]>
Co-authored-by: Nate Bosch <[email protected]>
|
PTAL @natebosch |
natebosch
approved these changes
Oct 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.