Skip to content

Remove VS Code mcp instructions in favor of Dart-Code setting. #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 2, 2025

Conversation

kenzieschmoll
Copy link
Contributor

@DanTup this addresses your comments on #201 (comment). Please let me know if there are other changes you'd like me to make to the docs.

Copy link

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Copy link

@DanTup DanTup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though one minor suggestion.

@kenzieschmoll
Copy link
Contributor Author

@jakemac53 added a note that these setup instructions require Dart 3.9.0 or later (current beta). LMK if you think I should tweak the version number to be more precise.

@DanTup similarly, I added a note that the VS Code setting requires Dart-Code v3.114 or later. Can you confirm this is the correct version to list here?

@DanTup
Copy link

DanTup commented Jun 30, 2025

@kenzieschmoll

@DanTup similarly, I added a note that the VS Code setting requires Dart-Code v3.114 or later. Can you confirm this is the correct version to list here?

Yep, that's correct - that version will be released tomorrow and includes all the things we've previously discussed. Other changes LGTM too :)

@jakemac53
Copy link
Contributor

In the error message I used the exact dart dev version (3.9.0-163.0.dev) - afaik the beta channel for dart isn't really used much, the dev version is more common.

@DanTup
Copy link

DanTup commented Jun 30, 2025

@jakemac53

In the error message I used the exact dart dev version (3.9.0-163.0.dev) - afaik the beta channel for dart isn't really used much, the dev version is more common.

I presume it would be better for me to use this in Dart-Code too? Currently I just have 3.9.0-0 which is probably a bit wide.

@jakemac53
Copy link
Contributor

I presume it would be better for me to use this in Dart-Code too? Currently I just have 3.9.0-0 which is probably a bit wide.

Yeah, it likely won't matter for many people but you can be more specific

@kenzieschmoll kenzieschmoll merged commit 2541b6c into main Jul 2, 2025
15 checks passed
@kenzieschmoll kenzieschmoll deleted the more-readme branch July 2, 2025 22:43
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jul 8, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/64dfa7f..9b007b3):
  9b007b3  2025-07-07  Jacob MacDonald  Add failure reasons to tool call analytics events (dart-lang/ai#219)
  c8dc5da  2025-07-07  Jacob MacDonald  don't bail early when running in multiple roots (dart-lang/ai#218)
  2541b6c  2025-07-02  Kenzie Davisson  Remove VS Code mcp instructions in favor of Dart-Code setting. (dart-lang/ai#206)
  70daa1f  2025-07-02  Jacob MacDonald  release dart_mcp 0.3.0 (dart-lang/ai#216)
  a252a46  2025-07-01  Jacob MacDonald  add retry logic to try and make dtd_test less flaky (dart-lang/ai#214)
  9e0b973  2025-07-01  Jacob MacDonald  add a test that the arg parser library only depends on package:args (dart-lang/ai#213)

http (https://github.com/dart-lang/http/compare/e70a41b..7d2d87e):
  7d2d87e  2025-07-02  Brian Quinlan  Fix `Connection reset by peer` in protocol error tests (dart-lang/http#1786)

i18n (https://github.com/dart-lang/i18n/compare/ab90327..42c4932):
  42c49328  2025-07-07  Googler  No public description
  87fd0156  2025-07-07  Michael Goderbauer  [intl4x] Re-enable Windows (dart-lang/i18n#986)
  912a7720  2025-07-07  Copybara-Service  Merge pull request `#985` from dart-lang:fixConstantEvaluator
  52f5beeb  2025-07-07  Moritz  Small cleanups in intl4x (dart-lang/i18n#988)
  6e8ef245  2025-07-07  Moritz  squash

sync_http (https://github.com/dart-lang/sync_http/compare/dc54465..c07f96f):
  c07f96f  2025-07-03  Kevin Moore  Update to latest lints, required Dart 3.7 (google/sync_http.dart#55)

tools (https://github.com/dart-lang/tools/compare/7bf22c9..6282b35):
  6282b35e  2025-07-03  Lasse R.H. Nielsen  [Markdown] Fix HTML comment parser. (dart-lang/tools#2121)

web (https://github.com/dart-lang/web/compare/3e11172..fb8a149):
  fb8a149  2025-07-07  Nikechukwu  Add Support for Configuration of Dart JS Interop Gen (dart-lang/web#386)

Change-Id: Ib243021ed77846a8451f60fa320e5cf40e85aa27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/439320
Commit-Queue: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants