Add throttling for resource notifications #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
| @@ -37,8 +37,19 @@ base mixin ResourcesSupport on MCPServer { | |||
| final List<({ResourceTemplate template, ReadResourceHandler handler})> | |||
| _resourceTemplates = []; | |||
|
|
|||
| /// The list of currently subscribed resources by URI. | |||
| final Set<String> _subscribedResources = {}; | |||
| /// The currently subscribed resource [StreamController]s by URI. | |||
There was a problem hiding this comment.
can you be more specific of what type of URI is expected? (e.g. file uri, absolute, etc.)
There was a problem hiding this comment.
These can be any URI, as defined by the server.
jakemac53
commented
Apr 29, 2025
jakemac53
commented
Apr 29, 2025
natebosch
approved these changes
Apr 29, 2025
kenzieschmoll
approved these changes
Apr 29, 2025
Co-authored-by: Nate Bosch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in anticipation of potentially modeling runtime errors as resources, so they might be updated often. But it is in general a good practice to throttle these.