Skip to content

[web_socket] Adds WebSocketException.toString() #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AlexV525
Copy link
Contributor

Similar to WebSocketChannelException and ClientException, overriding the method would provide a readable format when referencing it in logs/consoles.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented May 1, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:cronet_http 1.3.3 already published at pub.dev
package:cupertino_http 2.1.1 already published at pub.dev
package:http 1.4.0-wip WIP (no publish necessary)
package:http2 3.0.0 ready to publish http2-v3.0.0
package:http_multi_server 3.2.2 already published at pub.dev
package:http_parser 4.1.2 already published at pub.dev
package:http_profile 0.1.1-wip WIP (no publish necessary)
package:ok_http 0.1.1-wip WIP (no publish necessary)
package:web_socket 1.0.0 already published at pub.dev
package:web_socket_channel 3.0.3 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

github-actions bot commented May 1, 2025

PR Health

Changelog Entry
Package Changed Files
package:web_socket pkgs/web_socket/lib/src/web_socket.dart

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ⚠️
File Coverage
pkgs/web_socket/lib/src/web_socket.dart 💔 54 % ⬇️ 11 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/http/example/main.dart

@brianquinlan brianquinlan merged commit 7568b5c into dart-lang:master May 1, 2025
30 of 32 checks passed
@AlexV525 AlexV525 deleted the feat/web-socket-exception-tostring branch May 1, 2025 22:20
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request May 5, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/95105e9..e4f9451):
  e4f9451a  2025-05-05  Jonas Finnemann Jensen  Fix duplicate entries of elements in a category when re-exported. (dart-lang/dartdoc#4043)
  876180bd  2025-05-01  dependabot[bot]  Bump github/codeql-action from 3.28.13 to 3.28.16 in the github-actions group (dart-lang/dartdoc#4045)

http (https://github.com/dart-lang/http/compare/63c477b..78d6114):
  78d6114  2025-05-02  Brian Quinlan  Add a new exception type `NSErrorClientException` (dart-lang/http#1763)
  7a2e7d5  2025-05-01  Brian Quinlan  Add a useful stringificiation to `WebSocketConnectionClosed` (dart-lang/http#1764)
  ccb6533  2025-05-01  dependabot[bot]  Bump the github-actions group across 1 directory with 4 updates (dart-lang/http#1761)
  7568b5c  2025-05-02  Alex Li  [web_socket] Adds `WebSocketException.toString()` (dart-lang/http#1756)
  3e4cceb  2025-05-01  Brian Quinlan  Make response headers tests pass on firefox (dart-lang/http#1762)
  5704b0c  2025-05-01  Brian Quinlan  [cronet_http/cupertino_http]: Fixes bugs where cancelling `StreamedResponse.stream` did not sever the connection (dart-lang/http#1760)

test (https://github.com/dart-lang/test/compare/c3755d8..55d1f9e):
  55d1f9ed  2025-05-05  Fichtelcoder  Fix typos in json_reporter documentation (dart-lang/test#2493)

vector_math (https://github.com/google/vector_math.dart/compare/39cafd4..0279cb8):
  0279cb8  2025-05-01  Ömer Sinan Ağacan  Improve performance of functions with dynamic arguments (google/vector_math.dart#345)

Change-Id: I9a67b997ebcf7ebe29162f8f524628013d53af5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426581
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants