-
Notifications
You must be signed in to change notification settings - Fork 213
Add exception about extension members in error about nullable receivers #4318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eernstg
wants to merge
1
commit into
main
Choose a base branch
from
spec_nullable_receiver_error_apr25
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Does "extension members" include extension type members, because you are allowed to call those on an extension type which doesn't implement
Object
.)Probably correct and good fix, but still indirect.
What would happen if we remove this paragraph entirely?
I feel like it should fall through to some rule that says that you can't call somethin which isn't there, and where there is also no extension member. That is, a member invocation would do a lookup on the static type to see if there is a member. If so, see if it's compatible. If not, check for applicable extension functions. If not one such, it's an error.
If not having this paragraph would err out missing something which says which members
T?
has, then that's what we should write:Then it's just an error to call a member that a type doesn't have, as usual.