[DAS] Fixes triggers for Create class and Create getter quick-fixes

Fixes: #60527
Change-Id: I85e75c89d9b6057f516e4356865cee19c6eee27c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422161
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
Auto-Submit: Felipe Morschel <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/correction/dart/create_class.dart

@@ -56,7 +56,9 @@ class CreateClass extends ResolvedCorrectionProducer {
       }
       className = targetNode.name2.lexeme;
       requiresConstConstructor |= _requiresConstConstructor(targetNode);
-    } else if (targetNode is SimpleIdentifier) {
+    } else if (targetNode case SimpleIdentifier(
+      :var parent,
+    ) when parent is! PropertyAccess && parent is! PrefixedIdentifier) {
       className = targetNode.nameOfType;
       requiresConstConstructor |= _requiresConstConstructor(targetNode);
     } else if (targetNode is PrefixedIdentifier) {

pkg/analysis_server/lib/src/services/correction/dart/create_getter.dart

@@ -145,8 +145,8 @@ class CreateGetter extends CreateFieldOrGetter {
     InstanceElement? targetElement;
     if (target is ExtensionOverride) {
       targetElement = target.element2;
-    } else if (target is Identifier && target.element is ExtensionElement) {
-      targetElement = target.element as InstanceElement?;
+    } else if (target case Identifier(element: InstanceElement element)) {
+      targetElement = element;
       staticModifier = true;
     } else if (target != null) {
       // prepare target interface type

pkg/analysis_server/test/src/services/correction/fix/create_class_test.dart

@@ -41,6 +41,30 @@ class Test {
     ]);
   }
 
+  Future<void> test_class_instanceMember() async {
+    await resolveTestCode('''
+class A {
+}
+
+void f() {
+  int _ = A().Test;
+}
+''');
+    await assertNoFix();
+  }
+
+  Future<void> test_class_staticMember() async {
+    await resolveTestCode('''
+class A {
+}
+
+void f() {
+  int _ = A.Test;
+}
+''');
+    await assertNoFix();
+  }
+
   Future<void> test_extends() async {
     await resolveTestCode('''
 class MyClass extends BaseClass {}

pkg/analysis_server/test/src/services/correction/fix/create_getter_test.dart

@@ -620,7 +620,29 @@ void f(A a) {
     await assertNoFix();
   }
 
-  Future<void> test_static() async {
+  Future<void> test_static_class() async {
+    await resolveTestCode('''
+class C {
+}
+
+void f(String s) {
+  int v = C.test;
+  print(v);
+}
+''');
+    await assertHasFix('''
+class C {
+  static int get test => null;
+}
+
+void f(String s) {
+  int v = C.test;
+  print(v);
+}
+''');
+  }
+
+  Future<void> test_static_extension() async {
     await resolveTestCode('''
 extension E on String {
 }