Skip to content

Create class and Create getter bugs #60527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FMorschel opened this issue Apr 11, 2025 · 1 comment
Closed

Create class and Create getter bugs #60527

FMorschel opened this issue Apr 11, 2025 · 1 comment
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-quick-fix Issues with analysis server (quick) fixes P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@FMorschel
Copy link
Contributor

I started working on a new quick-fix today:

class ConvertToForeach extends ResolvedCorrectionProducer {
  ConvertToForeach({required super.context});

  @override
  CorrectionApplicability get applicability =>
      // This operation has side effects, so it should not be applied
      // automatically.
      CorrectionApplicability.singleLocation;

  @override
  FixKind get fixKind => DartFixKind.CONVERT_TO_FOREACH;  // undefined_getter at `CONVERT_TO_FOREACH`

  @override
  Future<void> compute(ChangeBuilder builder) async {

  }
}

This has two problems:

  • "Create class" triggering
  • "Create getter" not triggering

Image

@FMorschel FMorschel added the area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. label Apr 11, 2025
@bwilkerson bwilkerson added devexp-quick-fix Issues with analysis server (quick) fixes P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Apr 11, 2025
@FMorschel
Copy link
Contributor Author

Here is the CL for this https://dart-review.googlesource.com/c/sdk/+/422161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-quick-fix Issues with analysis server (quick) fixes P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants