The analyzer should parse asserts in initializer lists.

[lrhn]

See #27141 for details.

The analyzer should accept an assert "expression" (like an assert statement without a trailing ;) as an element in initializer lists.

To enable: add the flag enableAssertInitializer in the language section of the .analysis_options file. Here is an example:

analyzer:
  language:
    enableAssertInitializer: true

As an initial implementation, the analyzer can skip analyzing the assertion completely.

It would be great if it could also evaluate any assert in a const context (in an initializer of a const constructor which is used to create a compile-time constant value). This would enable earlier errors for the team that is experimenting with the feature.

[eseidelGoogle]

FYI @pq

[bwilkerson]

As of https://codereview.chromium.org/2282233002/ the analyzer now accepts the new syntax if the flag enableAssertInitializer is included in the language section of the analysis options file.

The syntax is not yet captured in the AST structure, nor is any error checking performed, but this should allow clients to begin to experiment with using the feature without complaints from the analyzer.

[sethladd]

Thanks! We'll give it a shot.

[sethladd]

Hi @bwilkerson thanks for starting this feature.

Could we add support for checking if the constructs inside of initializer asserts are valid?

See flutter/flutter#5865 (comment) which I read as "surprised that a call to any was allowed in an initializer const assert".

We're not confident that we're using this feature correctly until the analyzer warns/hints to us if we've used non-const expressions in initializer const asserts.

Thanks!

[bwilkerson]

I believe that https://codereview.chromium.org/2492633002/ implements the rest of the analysis for this feature. Note that the formatter doesn't yet understand the new syntax.

[sethladd]

Thanks for the patch. Cc @munificent to check if there is a formatter issue
to track

On Thu, Nov 10, 2016, 12:02 PM Brian Wilkerson notifications@github.com
wrote:

I believe that https://codereview.chromium.org/2492633002/ implements the
rest of the analysis for this feature. Note that the formatter doesn't yet
understand the new syntax.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#27142 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAVZyQjHFtOCJXCy4TZ3lsDHKdltYl9ks5q8040gaJpZM4Jr8Rv
.