Calling both callbackDone and reportTestError has weird behavior

[nex3]

Consider the following test code:

  asyncTest('test 1', 1, () {
    new Timer(1, (_) {
      reportTestError('error', '');
      callbackDone();
    });
  });

  asyncTest('test 2', 1, () {
    new Timer(1, (_) {
      reportTestError('error', '');
      callbackDone();
    });
  });

This will report an error for test 1, but it will report test 2 as passing. If the callbackDone call is removed, then both tests are reported as failing.

Ideally, callbackDone could be called after reportTestError to allow for asynchronous post-test cleanup. Failing that, though, it would be nice for this to have a descriptive error message.

[sigmundch]

(adding some documentation here from our local discussions)

There are two issues here:

• The asyncTest/callbackDone API is going away.
• The reportTestError is not intended to be used from actual tests

Instead of asyncTest, we are favoring the new style of specifying asynchronous tests via 'expectAsync'. For instance:

test('foo', () {
  setTimeout(expectAsync0(() { ... }, 0);
});

(see more details in the top-level documentation of unittest.dart)

We should do something with 'reportTestError', maybe rename it. It is meant to be used in setting up the unittest library to report errors that escaped the test library but where caught in some other way (e.g. via window.onerror). Errors within a test should be automatically handled by the test framework.

[gramster]

Closing this, it is about obsolete APIs.

---

Added AssumedStale label.