Skip to content

Missing hot reload rejection error when a class type parameters change #60101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nshahan opened this issue Feb 11, 2025 · 1 comment
Open

Missing hot reload rejection error when a class type parameters change #60101

nshahan opened this issue Feb 11, 2025 · 1 comment
Assignees
@nshahan
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop P2 A bug or feature request we're likely to work on web-dev-compiler web-hot-reload Issues related to stateful hot reload on the web

Comments

@nshahan
Copy link
Contributor

nshahan commented Feb 11, 2025

Reloads that change the number of type parameters in a generic class should be rejected.

Related tests:

hot_reload/change_instance_format6
hot_reload/change_instance_format7_ddc
hot_reload/change_instance_format9
@nshahan nshahan self-assigned this Feb 11, 2025
@nshahan nshahan added web-dev-compiler area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop labels Feb 11, 2025
@biggs0125 biggs0125 added the web-hot-reload Issues related to stateful hot reload on the web label Feb 11, 2025
copybara-service bot pushed a commit that referenced this issue Feb 12, 2025
@nshahan
[ddc] Add hot reload rejection for type parameters
b12fedc 
Changing the number of type parameters on a class is not supported
in a hot reload.

Issue: #60101
Change-Id: I3e397f26ca80e655dcb3d2807ddefd59c89adddb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409381
Commit-Queue: Nicholas Shahan <[email protected]>
Reviewed-by: Mark Zhou <[email protected]>
@nshahan
Copy link
Contributor Author

nshahan commented May 2, 2025

Still failing one test:

hot_reload/change_instance_format9

Need to find classes that have had a change of type arguments via their supers. Existing instances will potentially not have the type arguments if needed.

@nshahan nshahan added the P2 A bug or feature request we're likely to work on label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshahan nshahan

Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop P2 A bug or feature request we're likely to work on web-dev-compiler web-hot-reload Issues related to stateful hot reload on the web
Projects
Web Hot Reload - Known Issues
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@biggs0125 @nshahan