Debugging breakpoints broken after hot reload on the web #60186
Comments
biggs0125
added
web-dev-compiler
area-web-js
…ed files, and publish 24.3.10 dart-lang/sdk#60186 Breakpoints are currently broken when doing a hot reload. They either are not re-mapped or point to the wrong location. For now, we should disable them in the changed libraries. In order to do this, we split the hot reload implementation into 2 in order to get the list of changed libraries. The call to hot reload will later use the cached list to call out to the embedder.
…ed files, and publish 24.3.10 (#2606) dart-lang/sdk#60186 Breakpoints are currently broken when doing a hot reload when files change. They either are not re-mapped or point to the wrong location. For now, we should disable them in the changed libraries. In order to do this, we split the hot reload implementation into 2 in order to get the list of changed libraries. The call to hot reload will later use the cached list to call out to the embedder. Note that this likely won't change any behavior. New JS files already don't have breakpoints, so this PR should be mostly about cleaning up bookkeeping.
|
dart-lang/webdev#2606 disables them on changed files for now. We're working on getting them working and reregistered still. |
FWIW, the VM doesn't try and re-register breakpoints in changed libraries. It's up to the service clients to reset them after the reload completes. |
Agreed. We chatted about this, but DWDS still needs to send the right events for the client to do so. I've tried that (in combination with the expected pause), but the program doesn't resume so I need to debug further on where things are going wrong. And separately, the breakpoint mapping on files seems off so I'll need to fix that. |
nshahan
added
the
P1
Handle re-registering breakpoints after a hot reload based on new code locations.
The text was updated successfully, but these errors were encountered: