Tags: dart-lang/test
Tags
Release fake_async v1.3.3 (#2453) Needed by bug-fix in SDK.
Merge `package:test_descriptor` (#2424) - [x] Move and fix workflow files, labeler.yaml, and badges in the README.md - [x] Rev the version of the package, so that pub.dev points to the correct site - [x] Add a line to the changelog: ``` * Move to `dart-lang/test` monorepo. ``` - [x] Add the package to the top-level readme of the monorepo: ``` | [test_descriptor](pkgs/test_descriptor/) | An API for defining and verifying files and directory structures. | [](https://github.com/dart-lang/tools/issues?q=is%3Aissue+is%3Aopen+label%3Apackage%3Atest_descriptor) | [](https://pub.dev/packages/test_descriptor) | ``` - [ ] **Important!** Merge the PR with 'Create a merge commit' (enabling then disabling the `Allow merge commits` admin setting) - [x] Update the auto-publishing settings on https://pub.dev/packages/test_descriptor/admin - [x] Add the following text to https://github.com/dart-lang/test_descriptor/:' ``` > [!IMPORTANT] > This repo has moved to https://github.com/dart-lang/test/tree/master/pkgs/test_descriptor ``` - [ ] Publish using the autopublish workflow - [x] Push tags to GitHub using ``` git tag --list 'test_descriptor*' | xargs git push origin ``` - [x] Close open PRs in dart-lang/test_descriptor with the following message: ``` Closing as the [dart-lang/test_descriptor](https://github.com/dart-lang/test_descriptor) repository is merged into the [dart-lang/test](https://github.com/dart-lang/test) monorepo. Please re-open this PR there! ``` - [x] Transfer issues by running ``` dart run pkgs/repo_manage/bin/report.dart transfer-issues --source-repo dart-lang/test_descriptor --target-repo dart-lang/test --add-label package:test_descriptor --apply-changes ``` - [ ] Archive https://github.com/dart-lang/test_descriptor/ --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback. </details>
](https://pub.dev/packages/test_descriptor){kind=link}
Merge `package:test_process` (#2425) - [x] Move and fix workflow files, labeler.yaml, and badges in the README.md - [x] Rev the version of the package, so that pub.dev points to the correct site - [x] Add a line to the changelog: ``` * Move to `dart-lang/test` monorepo. ``` - [x] Add the package to the top-level readme of the monorepo: ``` | [test_process](pkgs/test_process/) | Test processes: starting; validating stdout and stderr; checking exit code | [](https://github.com/dart-lang/tools/issues?q=is%3Aissue+is%3Aopen+label%3Apackage%3Atest_process) | [](https://pub.dev/packages/test_process) | ``` - [ ] **Important!** Merge the PR with 'Create a merge commit' (enabling then disabling the `Allow merge commits` admin setting) - [x] Update the auto-publishing settings on https://pub.dev/packages/test_process/admin - [x] Add the following text to https://github.com/dart-lang/test_process/:' ``` > [!IMPORTANT] > This repo has moved to https://github.com/dart-lang/test/tree/master/pkgs/test_process ``` - [ ] Publish using the autopublish workflow - [ ] Push tags to GitHub using ``` git tag --list 'test_process*' | xargs git push origin ``` - [ ] Close open PRs in dart-lang/test_process with the following message: ``` Closing as the [dart-lang/test_process](https://github.com/dart-lang/test_process) repository is merged into the [dart-lang/test](https://github.com/dart-lang/test) monorepo. Please re-open this PR there! ``` - [ ] Transfer issues by running ``` dart run pkgs/repo_manage/bin/report.dart transfer-issues --source-repo dart-lang/test_process --target-repo dart-lang/test --add-label package:test_process --apply-changes ``` - [ ] Archive https://github.com/dart-lang/test_process/ --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback. </details>
](https://pub.dev/packages/test_process){kind=link}
Fix hang after multiple precompiled browser tests (#2422) Fixes #2294 Avoid creating extra unexpected BrowserManager instances by caching the future in the `_browserManagers` map without any async delay. Previously it was possible for two managers to be created if the second suite is loaded before the first suite's `compilerSupport` was resolved. This was not a problem for tests that get compiled by the test runner because the compilation would delay the second suite load until after the first suite's `compilerSupport` has resolved. It is not a problem when running without concurrency because that delays the second suite load. Add a concurrency argument to the regression test, otherwise the default is to run with concurrency 1 which works around the bug.
Fix hang after multiple precompiled browser tests (#2422) Fixes #2294 Avoid creating extra unexpected BrowserManager instances by caching the future in the `_browserManagers` map without any async delay. Previously it was possible for two managers to be created if the second suite is loaded before the first suite's `compilerSupport` was resolved. This was not a problem for tests that get compiled by the test runner because the compilation would delay the second suite load until after the first suite's `compilerSupport` has resolved. It is not a problem when running without concurrency because that delays the second suite load. Add a concurrency argument to the regression test, otherwise the default is to run with concurrency 1 which works around the bug.
Update the use of 'package:shelf_web_socket's `webSocketHandler` meth… …od (#2421) - add a 2nd argument to the closure passed into package:shelf_web_socket's `webSocketHandler` method - widen the dep on package:shelf_web_socket This will allow us to add more type info to the closure that `webSocketHandler` expects; it's currently an untyped Function. See also dart-lang/shelf#457 and dart-lang/shelf#463. This forward declares compatibility with `3.0` of `package:shelf_web_socket`; I _think_ this is necessary - as `dart test` uses both package:test and package:shelf_web_socket - but happy to hear otherwise. --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback. </details> --------- Co-authored-by: Jacob MacDonald <[email protected]>
PreviousNext