Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dart-lang/tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f14bf2e
Choose a base ref
...
head repository: dart-lang/tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 295ff92
Choose a head ref
  • 2 commits
  • 14 files changed
  • 2 contributors

Commits on Aug 9, 2023

  1. Clean up on dart docs across all dart files under lib (#142) 

    * Clean up across all dart files under lib

* Fix format

* Apply suggestions from code review

Co-authored-by: Christopher Fujino <[email protected]>

---------

Co-authored-by: Christopher Fujino <[email protected]>
    @eliasyishak @christopherfujino
    eliasyishak and christopherfujino authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    bc6c9f0 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Fix empty string for CLIENT_ID from being sent when user decides to… 

    … opt in (#144)

* unified_analytics and graphs: cleanup lints, bump pkg deps (#108)

* Fix to conditional logic for setting telemetry

* Test Client id not empty + different from original id

* Test using a new instance to check client id

* Reread the new client id after clearing it
    @eliasyishak
    eliasyishak authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    295ff92 View commit details
    Browse the repository at this point in the history
Loading