unified_analytics and graphs: cleanup lints, bump pkg deps #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type-infra
|
I'm about to merge in Which will be bumping the analytics package to 2.0.0 actually. I'll request changes once that is changed. But I'm curious as to why there were so many changes to how I typed variables? Is that how we want to handle code within dart-lang repos? |
|
@eliasyishak – we just don't type things on the left. Inference is nice! |
devoncarew
approved these changes
Jun 1, 2023
| file: ^6.1.4 | ||
| http: ^0.13.5 | ||
| file: '>=6.1.4 <8.0.0' | ||
| http: '>=0.13.5 <2.0.0' |
eliasyishak
added a commit
to eliasyishak/tools
that referenced
this pull request
Jun 1, 2023
eliasyishak
added a commit
that referenced
this pull request
Jul 13, 2023
* unified_analytics and graphs: cleanup lints, bump pkg deps (#108) * Update documentation for updated fields * Add new keys to `LogFileStats` and fix tests * Remove example from test docstring * Update changelog + bump version
eliasyishak
added a commit
that referenced
this pull request
Aug 7, 2023
* unified_analytics and graphs: cleanup lints, bump pkg deps (#108) * Removing unused Noop classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.