-
Notifications
You must be signed in to change notification settings - Fork 50
[unified analytics] fix lintUsageCount
docs
#2053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR Health
Breaking changes
|
Package | Change | Current Version | New Version | Needed Version | Looking good? |
---|---|---|---|---|---|
unified_analytics | Breaking | 7.0.1 | 7.0.2 | 8.0.0 Got "7.0.2" expected >= "8.0.0" (breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check
.
Coverage ✔️
File | Coverage |
---|---|
pkgs/unified_analytics/lib/src/event.dart | 💚 98 % |
This check for test coverage is informational (issues shown here will not fail the PR).
API leaks ⚠️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|---|
unified_analytics | Condition PersistedSurvey GAClient UserProperty |
This check can be disabled by tagging the PR with skip-leaking-check
.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
Files |
---|
pkgs/bazel_worker/benchmark/benchmark.dart |
pkgs/bazel_worker/example/client.dart |
pkgs/bazel_worker/example/worker.dart |
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart |
pkgs/boolean_selector/example/example.dart |
pkgs/clock/lib/clock.dart |
pkgs/clock/lib/src/clock.dart |
pkgs/clock/lib/src/default.dart |
pkgs/clock/lib/src/stopwatch.dart |
pkgs/clock/lib/src/utils.dart |
pkgs/clock/test/clock_test.dart |
pkgs/clock/test/default_test.dart |
pkgs/clock/test/stopwatch_test.dart |
pkgs/clock/test/utils.dart |
pkgs/coverage/lib/src/coverage_options.dart |
pkgs/coverage/test/collect_coverage_config_test.dart |
pkgs/coverage/test/config_file_locator_test.dart |
pkgs/html/example/main.dart |
pkgs/html/lib/dom.dart |
pkgs/html/lib/dom_parsing.dart |
pkgs/html/lib/html_escape.dart |
pkgs/html/lib/parser.dart |
pkgs/html/lib/src/constants.dart |
pkgs/html/lib/src/encoding_parser.dart |
pkgs/html/lib/src/html_input_stream.dart |
pkgs/html/lib/src/list_proxy.dart |
pkgs/html/lib/src/query_selector.dart |
pkgs/html/lib/src/token.dart |
pkgs/html/lib/src/tokenizer.dart |
pkgs/html/lib/src/treebuilder.dart |
pkgs/html/lib/src/utils.dart |
pkgs/html/test/dom_test.dart |
pkgs/html/test/parser_feature_test.dart |
pkgs/html/test/parser_test.dart |
pkgs/html/test/query_selector_test.dart |
pkgs/html/test/selectors/level1_baseline_test.dart |
pkgs/html/test/selectors/level1_lib.dart |
pkgs/html/test/selectors/selectors.dart |
pkgs/html/test/support.dart |
pkgs/html/test/tokenizer_test.dart |
pkgs/pubspec_parse/test/git_uri_test.dart |
pkgs/stack_trace/example/example.dart |
pkgs/watcher/test/custom_watcher_factory_test.dart |
pkgs/yaml_edit/example/example.dart |
Since this doc is only for our own consumption, I don't see a need to update the changelog. Let me know if you all think otherwise! |
@@ -622,7 +622,7 @@ final class Event { | |||
/// Event that is emitted periodically to report the number of times each lint | |||
/// has been enabled. | |||
/// | |||
/// [count] - the number of contexts in which the lint was enabled. | |||
/// [count] - the number of options files in which the lint was enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that's quite accurate either.
The implementation looks at the lints enabled in a given analysis context (though I don't think that's what it should be doing). If you have a file that enables a given rule, and that file includes another file that also enables the same rule, we only count that the rule is enabled after combining the options from all of the included files. It doesn't actually count the number of files in which it was enabled.
We need to figure out what data we want to be collecting in the current world. For example, we might want to union the set of lints enabled in all of the analysis options files used in a given context. I think that's probably closest to the data we were collecting before. It's possible, though, that there's a better way to collect the data (or a different set of data that we should be collecting).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point. I thought about this a little and thought better of suggesting we would need to track implicit (e.g., via an include) vs. explicit enablement. I'm just not sure we care too deeply. I think what we do care about is when a user draws a line around some code and says they want it analyzed in a particular way, what lints have they opted in to in that area. That used to correspond to an analysis context implementation and now it doesn't. Conceptually it's still sort of a context for analysis though.
In the end, I guess I'm compelled to correct the inaccuracy of suggesting this data corresponds to AnalysisContext
objects and am OK with replacing it with another inaccuracy for want of an easy way to communicate the nuance.
But all of that said, I don't feel incredibly strongly so I'm happy to update or drop this proposed change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can buy that argument.
The current docs are inaccurate. In times of yore, it was true that each options file implied a fresh context but not any more so what this count is actually tracking is number of occurences in an options file.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.