Skip to content

Add conversions between Dart's Uri and the JS URL #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

nex3
Copy link
Member

@nex3 nex3 commented Apr 30, 2025

No description provided.

@nex3 nex3 force-pushed the url-conversions branch from 2ab3b0d to 205b8d9 Compare April 30, 2025 00:29
@nex3 nex3 force-pushed the url-conversions branch from 205b8d9 to d83c2a3 Compare April 30, 2025 00:31
@kevmoo kevmoo requested a review from srujzs April 30, 2025 18:45
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Natalie!

@kevmoo kevmoo merged commit f1becf0 into dart-lang:main Apr 30, 2025
15 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request May 2, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

i18n (https://github.com/dart-lang/i18n/compare/de19436..e44af54):
  e44af54  2025-05-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/i18n#966)

test (https://github.com/dart-lang/test/compare/3ac991f..c3755d8):
  c3755d80  2025-05-01  dependabot[bot]  Bump github/codeql-action from 3.28.13 to 3.28.16 in the github-actions group (dart-lang/test#2492)
  935b8b04  2025-04-28  Danny Tuppeny  Allow specifying an explicit location for test/groups (dart-lang/test#2481)

tools (https://github.com/dart-lang/tools/compare/11f4cf7..92f10a9):
  92f10a9a  2025-04-30  Liam Appelbe  [coverage] Fix resume after shutdown error (dart-lang/tools#2079)
  7e8cb037  2025-04-29  Viral Verma  Add --fail-under flag for minimum coverage threshold (dart-lang/tools#2075)

web (https://github.com/dart-lang/web/compare/553c14d..f1becf0):
  f1becf0  2025-04-30  Natalie Weizenbaum  Add conversions between Dart's Uri and the JS URL (dart-lang/web#365)

Change-Id: Icc33983c9cc2cdad7add25494c92a21e8605b2a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425900
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants