Process events from other devtools pages #1517
Comments
annagrin
pushed a commit
to annagrin/webdev
that referenced
this issue
Feb 19, 2022
- Store dwdsStats on appServices for an app to make sure we are updating an reporting the same stats for an app. Previously, if the app services already existed, we would use incorrect object to report the stats, causing incorrect times and missing reports. - Set the times on dwdsStats when debug request arrives to make sure times are recorded only from the time when the user starts debugging. - Process `pageReady` events from any DevTools page, as DevTools does not always show the debugger page first. - Enabled previously skipped tests. Closes:dart-lang#1517
annagrin
pushed a commit
that referenced
this issue
Mar 7, 2022
* Fix issues in DevTools load time reporting - Store dwdsStats on appServices for an app to make sure we are updating an reporting the same stats for an app. Previously, if the app services already existed, we would use incorrect object to report the stats, causing incorrect times and missing reports. - Set the times on dwdsStats when debug request arrives to make sure times are recorded only from the time when the user starts debugging. - Process `pageReady` events from any DevTools page, as DevTools does not always show the debugger page first. - Enabled previously skipped tests. Closes:#1517 * Format
|
related: #2394 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dwds uses Devtools pageReady event from the debugger page to determine the load time of Devtools. For flutter apps, the first event would need to come from the Inspector page instead. Change dwds to record the first pageReady event from any page instead:
webdev/dwds/lib/src/dwds_vm_client.dart
Line 155 in 40f8265
The text was updated successfully, but these errors were encountered: