Skip to content

🔧: add tool config #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 5, 2024
Merged

🔧: add tool config #11

merged 4 commits into from
Dec 5, 2024

Conversation

nstarman
Copy link
Collaborator

@nstarman nstarman commented Dec 5, 2024

No description provided.

@nstarman nstarman added the 🔧 config Add or update configuration files. label Dec 5, 2024
@nstarman nstarman requested a review from jorenham December 5, 2024 06:25
@nstarman nstarman marked this pull request as ready for review December 5, 2024 06:41
@jorenham
Copy link
Collaborator

jorenham commented Dec 5, 2024

maybe also install the related deps?

@nstarman
🔧: add tool config
38d6553 
Signed-off-by: nstarman <[email protected]>
@nstarman
Copy link
Collaborator Author

nstarman commented Dec 5, 2024

[coverage] and [tool.pytest] have deps already in [dependency-groups].
ruff will be managed by pre-commit, which I've now added to [dependency-group]. We need to make the pre-commit yaml next (new PR).
mypy and the other static checkers we need to figure out. We could do mypy in pre-commit, or as a different step in the CI.

jorenham
jorenham reviewed Dec 5, 2024
View reviewed changes
@nstarman
Copy link
Collaborator Author

nstarman commented Dec 5, 2024

Squash merge plz.

@nstarman nstarman requested a review from jorenham December 5, 2024 17:21
jorenham
jorenham reviewed Dec 5, 2024
View reviewed changes
@nstarman
Copy link
Collaborator Author

nstarman commented Dec 5, 2024

Ok. Style should be much more consistent. I removed the alignments and spacing styles.

jorenham
jorenham reviewed Dec 5, 2024
View reviewed changes
@nstarman nstarman requested a review from jorenham December 5, 2024 21:10
nstarman and others added 2 commits December 5, 2024 16:20
@nstarman
🔧: update ruff config
600f012 
Signed-off-by: nstarman <[email protected]>
@nstarman @jorenham
💄: re-style the pyproject.toml
13d3a93 
Co-authored-by: Joren Hammudoglu <[email protected]>
Signed-off-by: Nathaniel Starkman <[email protected]>
@jorenham jorenham merged commit 3c3a2e0 into data-apis:main Dec 5, 2024
@nstarman nstarman deleted the infra/tool-config branch December 5, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorenham jorenham jorenham approved these changes

Assignees
No one assigned
Labels
🔧 config Add or update configuration files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nstarman @jorenham