Skip to content

prepare release 1.10.0 #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2025
Merged

prepare release 1.10.0 #283

merged 3 commits into from
Mar 12, 2025

Conversation

shivam2680
Copy link
Contributor

@shivam2680 shivam2680 commented Mar 12, 2025

Description

  1. Added change-log for latest release
  2. bumped up version to 1.10.0

Copy link
Collaborator

@jackyhu-db jackyhu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you bump the minor version as this change the property name

@kravets-levko
Copy link
Contributor

@jackyhu-db If I correctly understand recent changes, clientId property is still working as before, but now produces warning. If yes - then changing the build number is totally correct, because the release doesn't break library behavior (yet). You'd have to change minor number when you completely remove clientId.

Also, if it works as I think - there is another advantage for changing build number: most users will receive this release (because npm by default installs dependencies with ^ which allows build number changes), and they'll actually see the warning before you actually remove the clientId completely.

@jackyhu-db
Copy link
Collaborator

@jackyhu-db If I correctly understand recent changes, clientId property is still working as before, but now produces warning. If yes - then changing the build number is totally correct, because the release doesn't break library behavior (yet). You'd have to change minor number when you completely remove clientId.

Also, if it works as I think - there is another advantage for changing build number: most users will receive this release (because npm by default installs dependencies with ^ which allows build number changes), and they'll actually see the warning before you actually remove the clientId completely.

@kravets-levko minor version also has to be backward compatible, the difference between patch and minor version is if the change is a bug fix and client does not have to do nothing to adopt this change. Here we added a new property that is going to replace the old one. It is like backward compatible interface change and client has to make change in their code to use it, so I would prefer to use minor version so people is aware of this change.

@shivam2680 shivam2680 changed the title prepare release 1.9.1 prepare release 1.10.1 Mar 12, 2025
@shivam2680 shivam2680 changed the title prepare release 1.10.1 prepare release 1.10.0 Mar 12, 2025
@shivam2680 shivam2680 merged commit 6d6dd8b into main Mar 12, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants