Support custom Random Generators

[zyclonite]

Add support for using custom RandomGenerators like SplittableRandom for improved speed and less overhead

[what-the-diff]

PR Summary

• Updated Locality.java

  • This PR incorporates a more modern and effective random number generator technique by transforming the random parameter's type from Random to RandomGenerator in localeStringWithRandom and localeStringWithoutReplacement methods.
  • It also adjusts the Collections.shuffle method to effectively work with the new RandomGenerator type.

• Modified FakeValuesService.java

  • The code now imports the java.util.Random for potential future operational needs.
  • Minor formatting improvements have been introduced for consistency, including spaces around operators.

• Altered RandomService.java

  • Changes have been made in the random field and the constructor element from Random to RandomGenerator.
  • The getRandomInternal method is now updated to yield RandomGenerator instead of Random.

• Expanded RandomServiceTest.java

  • A new test method customRandomGenerator has been implemented which validates functionality when used with a SplittableRandom instance.

[kingthorin]

Could you revert the formatting changes?

Not that any of them are wrong but just to keep this focused on the relevant changes.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.50%. Comparing base (212f8ae) to head (62f0c6e).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1562      +/-   ##
============================================
+ Coverage     92.45%   92.50%   +0.04%     
- Complexity     3308     3312       +4     
============================================
  Files           329      329              
  Lines          6507     6510       +3     
  Branches        632      632              
============================================
+ Hits           6016     6022       +6     
+ Misses          338      337       -1     
+ Partials        153      151       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[zyclonite]

Could you revert the formatting changes?

Not that any of them are wrong but just to keep this focused on the relevant changes.

this was by mistake, removed it now

[kingthorin]

LGTM

[asolntsev]

Maybe I missed something, but what is the point of declaring parameter as RandomGenerator if we anyway cast it to Random? Then no any other types would work here...

[zyclonite]

because this new method does start to exist in jdk21... this would break the compatibility for jdk17

[zyclonite]

but good point - seems there is not test for that...

[zyclonite]

added a way to fix it now... but the same is true for RgxGen, so this would need to be fixed first

[zyclonite]

depends on curious-odd-man/RgxGen#108

[zyclonite]

the new version 3.0 of RgxGen supports RandomGenerator now
upgraded the version and fixed the implementation