Skip to content

Conversation

@m1so
Copy link
Contributor

@m1so m1so commented Dec 10, 2025

Summary by CodeRabbit

  • Chores
    • Internal updates for improved stability and compatibility.

Note: This release contains internal maintenance updates with no user-visible changes to functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

📝 Walkthrough

Walkthrough

The pull request updates the urllib3 dependency constraint in pyproject.toml. The minimum required version is bumped from 2.5.0 to 2.6.1, while maintaining the upper bound constraint of less than version 3 for Python 3.10 and above. This is a configuration-level dependency specification change with no modifications to source code.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title clearly and concisely describes the main change: updating urllib3 dependency to version 2.6.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a251c6b and 05ace02.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: Build and push artifacts for Python 3.11
  • GitHub Check: Build and push artifacts for Python 3.13
  • GitHub Check: Build and push artifacts for Python 3.10
  • GitHub Check: Build and push artifacts for Python 3.9
  • GitHub Check: Build and push artifacts for Python 3.12
  • GitHub Check: Typecheck - 3.13
  • GitHub Check: Test - Python 3.10
  • GitHub Check: Test - Python 3.12
  • GitHub Check: Test - Python 3.13
  • GitHub Check: Test - Python 3.11
  • GitHub Check: Test - Python 3.9
🔇 Additional comments (1)
pyproject.toml (1)

139-139: urllib3 2.6.1 release is valid—restores previously removed API methods.

urllib3 2.6.1 (released 2025-12-08) restores the HTTPResponse.getheaders() and HTTPResponse.getheader() methods (#3731), addressing backwards compatibility. The version bump is justified.


Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Dec 10, 2025
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

📦 Python package built successfully!

  • Version: 1.1.6.dev2+e74746c
  • Wheel: deepnote_toolkit-1.1.6.dev2+e74746c-py3-none-any.whl
  • Install:
    pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/1.1.6.dev2%2Be74746c/deepnote_toolkit-1.1.6.dev2%2Be74746c-py3-none-any.whl"

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.04%. Comparing base (a251c6b) to head (05ace02).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   73.04%   73.04%           
=======================================
  Files          93       93           
  Lines        5149     5149           
  Branches      754      754           
=======================================
  Hits         3761     3761           
  Misses       1144     1144           
  Partials      244      244           
Flag Coverage Δ
combined 73.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1so m1so force-pushed the mb/update-urllib3-to-2.6.1 branch from 596ce75 to 05ace02 Compare December 10, 2025 14:14
@m1so m1so marked this pull request as ready for review December 10, 2025 14:14
@m1so m1so requested a review from a team as a code owner December 10, 2025 14:14
@m1so m1so requested review from FilipPyrek and mfranczel and removed request for mfranczel December 10, 2025 14:14
@deepnote-bot
Copy link

🚀 Review App Deployment Started

📝 Description 🌐 Link / Info
🌍 Review application ra-43
🔑 Sign-in URL Click to sign-in
📊 Application logs View logs
🔄 Actions Click to redeploy
🚀 ArgoCD deployment View deployment
Last deployed 2025-12-10 14:22:49 (UTC)
📜 Deployed commit 134b10979978e467ce05374149a9893233777458
🛠️ Toolkit version e74746c

@m1so m1so merged commit 0674b44 into main Dec 10, 2025
35 checks passed
@m1so m1so deleted the mb/update-urllib3-to-2.6.1 branch December 10, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants