Skip to content

BREAKING: move std/flags to new std/cli sub-module #3530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 16, 2023

Conversation

lino-levan
Copy link
Contributor

Closes #3526. Marking as draft to prevent accidental merge before discussion is complete.

@iuioiua iuioiua changed the title BREAKING(flags): deprecate flags and move to cli top level folder BREAKING: move std/flags to new std/cli sub-module Nov 9, 2023
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead with this move.

@lino-levan lino-levan marked this pull request as ready for review November 10, 2023 21:08
@lino-levan lino-levan requested a review from kt3k as a code owner November 10, 2023 21:08
@nhrones
Copy link

nhrones commented Nov 10, 2023

@github-actions github-actions bot removed the examples label Nov 12, 2023
@lino-levan lino-levan requested a review from iuioiua November 12, 2023 18:55
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Couple nits.

@lino-levan lino-levan requested a review from iuioiua November 14, 2023 03:34
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, Lino.

@lino-levan
Copy link
Contributor Author

wait, don't merge yet

@lino-levan
Copy link
Contributor Author

Alright, should be mergeable now.

@iuioiua
Copy link
Contributor

iuioiua commented Nov 14, 2023

wait, don't merge yet

All good. I don't merge these more important PRs without Bartek's or Yoshiya's approval anyway 😛

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The core team is also in favor of std/cli idea.

@kt3k kt3k merged commit 16db0d5 into denoland:main Nov 16, 2023
@lino-levan lino-levan deleted the breaking-rename-flag-to-cli branch November 16, 2023 02:10
jlandowner added a commit to jlandowner/denobyexample that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: Move std/flags to std/cli
4 participants