-
Notifications
You must be signed in to change notification settings - Fork 654
BREAKING: move std/flags
to new std/cli
sub-module
#3530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
std/flags
to new std/cli
sub-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go ahead with this move.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Couple nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you, Lino.
wait, don't merge yet |
Alright, should be mergeable now. |
All good. I don't merge these more important PRs without Bartek's or Yoshiya's approval anyway 😛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The core team is also in favor of std/cli
idea.
Closes #3526. Marking as draft to prevent accidental merge before discussion is complete.