Skip to content

BREAKING: deprecate std/wasi #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2023
Merged

BREAKING: deprecate std/wasi #3732

merged 2 commits into from
Oct 31, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Oct 28, 2023 •
edited
Loading

After a discussion with @kt3k, there appears to be nearly no interest or development in this module. Best it be removed.

@github-actions github-actions bot added the wasi label Oct 28, 2023
@iuioiua iuioiua marked this pull request as ready for review October 28, 2023 02:51
@iuioiua iuioiua requested a review from kt3k as a code owner October 28, 2023 02:51
@iuioiua iuioiua mentioned this pull request Oct 28, 2023
Merged
@iuioiua iuioiua requested a review from bartlomieju October 28, 2023 03:12
kt3k
kt3k approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's deprecate as there seem no known usages. Also the download count of std/wasi is very low. Also we don't particularly encourage using wasi in Deno.

LGTM

@iuioiua iuioiua merged commit 71ef9c3 into main Oct 31, 2023
@iuioiua iuioiua deleted the deprecate-wasi branch October 31, 2023 03:37
@littledivy littledivy mentioned this pull request Oct 31, 2023
Open
@chrisdickinson chrisdickinson mentioned this pull request Jan 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
wasi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k