Skip to content

BREAKING(crypto): remove crypto.subtle.timingSafeEqual() method #3803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Nov 15, 2023

Note: this doesn't remove the timingSafeEqual() function, which is still available. This only removes the crypto.subtle.timingSafeEqual() method from the crypto.subtle interface.

See #3541

@iuioiua iuioiua changed the title BREAKING(crypto): remove crypto.subtle.timingSafeEqual() method. BREAKING(crypto): remove crypto.subtle.timingSafeEqual() method Nov 15, 2023
@iuioiua iuioiua marked this pull request as ready for review November 15, 2023 10:49
@iuioiua iuioiua requested a review from kt3k as a code owner November 15, 2023 10:49
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@iuioiua iuioiua merged commit a0b7e1f into main Nov 15, 2023
@iuioiua iuioiua deleted the remove-timingsafeequal-method branch November 15, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants