Skip to content

chore(cli): remove outdated todo comment #4787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 21, 2024

This todo comment is out-of-date as the test cases of Spinner were added in this PR #4713

@github-actions github-actions bot added the cli label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (c816314) to head (fd8155b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4787      +/-   ##
==========================================
- Coverage   91.88%   91.88%   -0.01%     
==========================================
  Files         486      486              
  Lines       41340    41338       -2     
  Branches     5325     5325              
==========================================
- Hits        37987    37985       -2     
  Misses       3296     3296              
  Partials       57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k merged commit aac208a into denoland:main May 21, 2024
@kt3k kt3k deleted the remove-outdated-todo-comment branch May 21, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants