Skip to content

test(uuid): add tests for invalid namespace UUID #4875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 29, 2024

Notice: These generate() functions only check the length of the namespace UUID and not its format. This behavior will be improved in #4874.

@iuioiua iuioiua requested a review from kt3k as a code owner May 29, 2024 07:59
@github-actions github-actions bot added the uuid label May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.36%. Comparing base (a0b0f4c) to head (310580c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4875   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files         488      488           
  Lines       41603    41603           
  Branches     5405     5407    +2     
=======================================
  Hits        38425    38425           
  Misses       3122     3122           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit fc3d376 into main May 29, 2024
@iuioiua iuioiua deleted the uuid-test-namespace branch May 29, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants