BREAKING(assert,testing): remove formatter
option from assertEquals()
#4893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
This change removes the option argument from
assertEquals()
. The only option within this argument wasformatter
, which allowed the user to format the actual and expected strings before being internally processed for display after they were determined to not be equal.Why has this change been made
This argument was removed because it didn't seem to have many use cases outside of some code previously internal to the Standard Library. The function's built-in formatter performs its job fine.
Migration guide
To migrate, simply remove the
options
argument fromassertEquals()
: