Skip to content

test(path): add test cases of isAbsolute(), joinGlobs(), and common() #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 30, 2024

part of #3713

This improves the test coverage of isAboslute, joinGlobs, and common in path package.

@github-actions github-actions bot added the path label May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.14%. Comparing base (f8f5444) to head (7729882).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4904      +/-   ##
==========================================
+ Coverage   92.09%   92.14%   +0.05%     
==========================================
  Files         488      488              
  Lines       38875    38873       -2     
  Branches     5398     5402       +4     
==========================================
+ Hits        35803    35821      +18     
+ Misses       3016     2996      -20     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title test(path): add test cases of isAbsolute, joinGlobs, and common test(path): add test cases of isAbsolute(), joinGlobs(), and common() May 30, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kt3k kt3k merged commit 9e3c1a2 into denoland:main May 30, 2024
@kt3k kt3k deleted the path-improve-tests branch May 30, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants