Skip to content

refactor(cli): cleanup use of @std/assert #4966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2024
Merged

refactor(cli): cleanup use of @std/assert #4966

merged 2 commits into from
Jun 5, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jun 5, 2024

Towards #4865

@iuioiua iuioiua requested a review from kt3k as a code owner June 5, 2024 03:32
@github-actions github-actions bot added the cli label Jun 5, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.15%. Comparing base (fbfcd24) to head (3f81f6e).

Files Patch % Lines
cli/parse_args.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4966      +/-   ##
==========================================
- Coverage   92.16%   92.15%   -0.01%     
==========================================
  Files         487      487              
  Lines       38740    38744       +4     
  Branches     5393     5397       +4     
==========================================
+ Hits        35703    35706       +3     
- Misses       2981     2982       +1     
  Partials       56       56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua mentioned this pull request Jun 5, 2024
Closed
13 tasks
kt3k
kt3k approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@iuioiua iuioiua merged commit dfbb3f6 into main Jun 5, 2024
12 checks passed
@iuioiua iuioiua deleted the cli-clean-assert branch June 5, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k