Skip to content

fix HumanName repr for names with single quotes #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

curlup
Copy link
Contributor

@curlup curlup commented Sep 29, 2022

eg HumanName("O'NEILL") would before this change return

<HumanName : [
	title: ''
	first: 'O'Neill'
	middle: ''
	last: ''
	suffix: ''
	nickname: ''
]>

and with the change it will be:

<HumanName : [
	title: ''
	first: "O'Neill"
	middle: ''
	last: ''
	suffix: ''
	nickname: ''
]>

I think it can be further improved by dropping manual multiline formatting etc, let me know if you would accept that as well.

@derek73
Copy link
Owner

derek73 commented Sep 30, 2022 via email

@derek73 derek73 added this to the 1.1.2 milestone Nov 14, 2022
@derek73 derek73 merged commit 3147993 into derek73:master Nov 14, 2022
@curlup
Copy link
Contributor Author

curlup commented Jan 13, 2023

it breaks single line logging for me. usually what i saw is that there's a pretty_print flag that does multiline, eg json.dump etc

@curlup
Copy link
Contributor Author

curlup commented Jan 13, 2023

obviously pretty_print can not be used for repr as a flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants